RFR 8062198: Add RowSetMetaDataImpl Tests and add column range validation to isdefinitlyWritable

huizhe wang huizhe.wang at oracle.com
Mon Oct 27 19:27:06 UTC 2014

Hi Lance,

Does  test37 needs to loop through all of the columns? There doesn't 
seem to be a differentiator or different factor between the columns, e.g 
if one column is set to auto_increment and another not, the results 
would be different. Also in the test, some of the setters seem to be 
invalid, for example, whether the column is auto_increment or not shall 
affect setters such as setPrecision, setScale, setNullable, isReadOnly, 
isWritable and etc., shouldn't it?


On 10/27/2014 11:06 AM, Lance Andersen wrote:
> Hi all,
> Need a reviewer for  the RowSetMetaDataImpl tests which also includes a fix to isDefinitelyWritable so that it validates the column index ranges
> Included are some minor housekeeping changes to remove redundant classes
> The webrev can be found at  http://cr.openjdk.java.net/~lancea/8062198/webrev.00/
> Best
> Lance
> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com

More information about the core-libs-dev mailing list