RFR: JDK-8051563: Convert JAXP function tests in xslt components: : org.apache.qetest.dtm package, org.apache.qetest.trax package to openjdk
tristan.yan at oracle.com
Fri Jan 2 18:49:40 UTC 2015
Hi Joe and Lance
Sorry for my late reply. I just uploaded the new webrev which is trying to limit minimal permissions for most of tests. The new changeset has two base classes; class JAXPBaseTest has only minimal set permissions; class JAXPFileBaseTest adds two permissions that need access local files in the directory directory test.src and test.classes. Most of tests only inherit JAXPBaseTest that provides only minimal set permissions. Some tests will inherit JAXPFileBaseTest because tests need access local files.
Please help to review the code.
> On Jan 2, 2015, at 10:39 AM, huizhe wang <huizhe.wang at oracle.com> wrote:
> Tristan is looking into adding an extension base class for about 60 tests that require file permission, then the current base class would indeed set "minimal" permission. So please wait for his update :-)
> On 12/30/2014 3:07 PM, Lance @ Oracle wrote:
>> Hi Tristan,
>> I will look at this but doubt I will get to this tomorrow
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 <tel:+1.781.442.2037>
>> Oracle Java Engineering
>> 1 Network Drive <x-apple-data-detectors://34/0>
>> Burlington, MA 01803 <x-apple-data-detectors://34/0>
>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>> Sent from my iPad
>> On Dec 30, 2014, at 5:28 PM, Tristan Yan <tristan.yan at oracle.com <mailto:tristan.yan at oracle.com>> wrote:
>>> Hi All
>>> Can I get your review on this change.
>>> http://cr.openjdk.java.net/~tyan/8051563/webrev.00/ <http://cr.openjdk.java.net/%7Etyan/8051563/webrev.00/> <http://cr.openjdk.java.net/~tyan/8051563/webrev.00/ <http://cr.openjdk.java.net/%7Etyan/8051563/webrev.00/>>
>>> These fixes originally come from bug https://bugs.openjdk.java.net/browse/JDK-8051563 <https://bugs.openjdk.java.net/browse/JDK-8051563> <https://bugs.openjdk.java.net/browse/JDK-8051563 <https://bugs.openjdk.java.net/browse/JDK-8051563>> as part of our XML test colocation work. ThIS change-set mainly covers tests for package org.apache.qetest.dtm and org.apache.qetest.trax.
>>> In the meantime I took steps at fixing some of our existed test code on below issues:
>>> 1. Add a base test class for all functional tests that enable security manager running. A limited minimal permissions set have been set for every test.
>>> 2. Remove all unnecessary exception capture for functional tests that we’re using testng to handle all the exceptions.
>>> 3. Use try-resource block to solve all possible resource leaks (including InputStream, OutputStream, Writer, Reader).
>>> Thanks a lot.
More information about the core-libs-dev