JAXP repo warnings fixed
Joseph D. Darcy
joe.darcy at oracle.com
Wed Mar 4 02:21:46 UTC 2015
I've skimmed over the patch and didn't see anything technically amiss.
However, I believe at least some of the changes, such as adding
@Deprecated and the generification updates will need to go through an
internal review process before they can be pushed.
Joe Wang (cc'ed as huizhe.wang at oracle.com) is the jaxp lead and he will
also need to review of the changes for jaxp-specific concerns.
On 3/3/2015 10:06 AM, Ivan St. Ivanov wrote:
> Hi Joe,
> The links are correct, but our server was down for a while. It is
> available now.
> On Tue, Mar 3, 2015 at 2:05 AM, Joseph D. Darcy <joe.darcy at oracle.com
> <mailto:joe.darcy at oracle.com>> wrote:
> Sorry for the belated reply, I tried the URLs and some obvious
> variations, but the webrevs didn't come up as being there.
> Have they been moved?
> On 2/18/2015 12:17 PM, Ivan St. Ivanov wrote:
> Hi Joe, core libs developers,
> Last night we had a hackathon in Bulgarian Java User Group.
> Its purpose was to work on fixing some compiler warnings in
> OpenJDK. The day before the meeting we ran the following command:
> make clean
> -Xmaxwarns 10000" DISABLE_WARNINGS="-Xlint:all" LOG=info images
> After that, looking at the build.log, we identified the
> following number of warnings per repo left to be fixed:
> 359 corba
> 100 jaxp
> 500 jaxws
> 0 nashorn
> We decided to take the jaxp repository, where the situation
> was the following:
> rawtypes 43
> unchecked 14
> serial 32
> cast 10
> dep-ann 1
> The latter three types were easy to fix. After we did them, we
> created our first webrev for the night:
> Later we continued with rawtypes and unchecked. We didn't fix
> them all, as some of the warnings concerned public method
> parameters, which change might virtually break client code.
> The good news here is that all these public methods belong to
> classes located in 'internal' packages. Which we hope will not
> be public any more once project Jigsaw meets java.xml module :)
> Anyway, this is the second webrev that we created:
> As its name implies, it contains all the fixes that we did
> last night.
> We would be happy to get feedback from you and even happier if
> this becomes our first contribution to OpenJDK as part of our
> adoption efforts.
> Ivan, Bulgarian JUG
More information about the core-libs-dev