RFR(M): 8078896: Add @modules as needed to the jdk_svc tests

Yekaterina Kantserova yekaterina.kantserova at oracle.com
Wed May 6 11:21:45 UTC 2015


Thanks fro your review!  Please see my comment inlined.

On 05/05/2015 11:00 PM, Mandy Chung wrote:
>> com.sun.management has been moved to jdk.management module.  The 
>> patch for JDK-8042901 is just integrated in jdk9/dev today.  Most, if 
>> not all, test/com/sun/management tests need updates to require 
>> @modules jdk.management.
>> There are several test/java/lang/management tests dependng on both 
>> java.lang.management and com.sun.management.  For tests only using 
>> java.lang.management API, @modules java.management is adequate.
>> test/com/sun/jdi/InterfaceMethodsTest.java
The copyright header contains already 2015.
>> test/com/sun/jdi/InterruptHangTest.java
The test has been missing copyrights, I've updated it with the copyright 
>>    Since you have updated the end year of the copyright header in 
>> most tests, I spot a couple and so mention it to you.
>> Otherwise looks good.  Thanks for doing this.

The new webrev can be found here: 

> About the test selection, one typical aspect of svc tests is to run a 
> j* tool in a child process (e.g. jinfo, jstack, jstat, jstatd,jcmd, 
> jps etc that are in jdk.jcmd module).   I would expect all 
> test/sun/tools/jcmd tests should have @modules jdk.jcmd and similiar 
> for other sun/tools/j* tests.  Are you thinking to come back in the 
> next round of test selection update?

As Alan pointed in his answer to this mail JTreg is not ready yet. I 
prefer to do it when it will be possible to test this change.

Best regards,

> Mandy 

More information about the core-libs-dev mailing list