RFR(M): 8078896: Add @modules as needed to the jdk_svc tests

Mandy Chung mandy.chung at oracle.com
Wed May 6 16:55:12 UTC 2015

On 05/06/2015 04:21 AM, Yekaterina Kantserova wrote:
> The new webrev can be found here: 
> http://cr.openjdk.java.net/~ykantser/8078896/webrev.02/

Looks good.

>> About the test selection, one typical aspect of svc tests is to run a 
>> j* tool in a child process (e.g. jinfo, jstack, jstat, jstatd,jcmd, 
>> jps etc that are in jdk.jcmd module).   I would expect all 
>> test/sun/tools/jcmd tests should have @modules jdk.jcmd and similiar 
>> for other sun/tools/j* tests.  Are you thinking to come back in the 
>> next round of test selection update?
> As Alan pointed in his answer to this mail JTreg is not ready yet. I 
> prefer to do it when it will be possible to test this change. 

Right the test selection is yet to be supported by jtreg and it's okay 
to add those in the next round.  As the tool  analyzing the test 
dependencies doesn't detect that, these multi-process tests would need 
to be analyzed in a different way.

Anyway, this patch looks good.


More information about the core-libs-dev mailing list