Naming of thread pools (Executors)

Peter Hansson peterhansson_se at
Sun May 17 07:55:49 UTC 2015


I would like create a patch for
MOTIVATION: Today thread pools created by the Executors method are always prefixed with "pool". The developer can work around this by providing his own ThreadFactory but if he wants to have the default JDK behaviour then it means he has to replicate code in the JDK. The string "pool" is hardcoded in the JDK. The fact that threads cannot be identified by their purpose is annoying especially when working with JEE servers.

The idea is to amend private classes Executors.DefaultThreadFactory and Executors.PrivilegedThreadFactory to optionally accept a name prefix in their constructor.Then methods Executors.defaultThreadFactory() and Executors.privilegedThreadFactory() will be overloaded to optionally accept a name prefix.
With this change the developer can now use a custom thread name prefix. If he wanted to do:

   Executors.newFixedThreadPool(3);  // standard, results in "pool" prefix

He could instead use a developer supplied ThreadFactory yet still using JDK's ThreadFactory:
   Executors.newFixedThreadPool(3, Executors.defaultThreadFactory("snmpworker"));

Good idea ?  Bad idea?  Any negative side effects ?

More information about the core-libs-dev mailing list