RFR [9] 8072839: JAX-B Plugability Layer: using java.util.ServiceLoader

Miroslav Kos miroslav.kos at oracle.com
Wed May 20 12:38:30 UTC 2015

On 19/05/15 22:44, Alan Bateman wrote:
> On 15/05/2015 16:13, Miroslav Kos wrote:
>> Hi everybody,
>> this is review request for: 8072839: JAX-B Plugability Layer: using 
>> java.util.ServiceLoader
>> The JAX-B API changed a little bit - proprietary ServiceLoader-like 
>> code has been replaced by java.util.ServiceLoader. This change is 
>> required by Jigsaw, old configuration way still supported.
>> JBS:https://bugs.openjdk.java.net/browse/JDK-8072839
>> webrev: http://cr.openjdk.java.net/~mkos/8072839/jaxws.02/index.html
> I skimmed through this and it mostly looks okay. Some really long 
> (200+) lines but that seems to be normal in this area. At some point 
> it would be good to do a wider pass over this code and replace the old 
> style tags (<tt> etc.) with newer forms.
> In JAXBContext it looks likes a typo "loading facilities" when I 
> assume it should be "loading facility".
> Are there any new tests for this? Existing tests will exercise some of 
> this but I don't see any tests that will exercise JAXBContextFactory.
> -Alan.
Thanks for checking - would you be ok with addressing javadoc later? Of 
course, typo can be fixed easily right away ...

Regarding tests - I created new tests for many different setup 
combination, but they require environment setup (property files in jdk 
conf dir, java.util.ServiceLoader descriptors, System property). The 
tests are using bash scipting (testing different env combinations) and I 
don't have currently jtreg version of those. To test the glassfish part, 
I ran glassfish smoke tests.


More information about the core-libs-dev mailing list