Review Request 8074432: Move jdeps to jdk.compiler module
mandy.chung at oracle.com
Mon May 25 19:28:12 UTC 2015
Meant to include jigsaw-dev in the initial post.
> On May 25, 2015, at 12:16 AM, Alan Bateman <alan.bateman at oracle.com> wrote:
> On 24/05/2015 05:00, Mandy Chung wrote:
>> This will move jdeps to the same module as other langtools javac and javap.
>> Webrev at:
>> This is the final change to resolve the open issue JDK-8072601 (Re-examine jdk.runtime and jdk.dev modules) for JEP 200.
> I don't see any issues with the patch but I wonder if this is a case where we should introduce jdk.jdeps rather than putting the tool in the jdk.compile module.
serialver and javap are in jdk.compiler that is an appropriate home for jdeps while I don’t particularly like it since it isn’t clear to tell from jdk.compiler module name where jdeps is there.
The tool modules have been evolved a bit and some tools are put in its own module such as jdk.pack200, jdk.policytool, jdk.javadoc, jdk.jconsole, jdk.rmic etc. that are organized around its primary tool which is easy to name, document, and understand.
Putting jdeps in jdk.jdeps module makes it easy where to find jdeps that is an attractive option.
This also opens up the option to move jdeps to jdk repo in the future - it is just a side point and jdeps is currently being used as an interim solution to verify module boundaries until the module system is moving further along.
I will post a revised webrev.
> A passing comment is that I see we run these tools with -Xms8m, we should re-visit that some day.
Yes - we should re-visit this for the launchers we have.
More information about the core-libs-dev