RFR:JDK-8071919 :Add java.time.Clock.tickMillis(ZoneId zone) method

Roger Riggs Roger.Riggs at Oracle.com
Fri Nov 13 15:53:36 UTC 2015

Hi Nadeesh,

One suggestion:

Replace "This clock will always have the other than milli part of 
nano-of-second field set to zero."
Though similar to the other methods, the "other than milli part" is awkward.


"This clock will always have the nano-of-second field truncated to 

The rest looks fine.

Thanks, Roger

On 11/13/2015 6:00 AM, nadeesh tv wrote:
> Hi all,
> Please review a fix for Bug Id 
> -https://bugs.openjdk.java.net/browse/JDK-8071919 
> <https://bugs.openjdk.java.net/browse/JDK-8071919>
> Issue - Add java.time.Clock.tickMillis(ZoneId zone) method
> webrev - http://cr.openjdk.java.net/~ntv/8071919/webrev.01/ 
> <http://cr.openjdk.java.net/%7Entv/8071919/webrev.01/>
> -- 
> Thanks and Regards,
> Nadeesh TV

More information about the core-libs-dev mailing list