Code Review for JEP 259: Stack-Walking API
mandy.chung at oracle.com
Tue Nov 17 20:10:54 UTC 2015
> On Nov 17, 2015, at 10:42 AM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
> On 17/11/15 01:13, Mandy Chung wrote:
>> I’d like to get the code review done by this week.
>> I renamed the static factory method from create to getInstance since “create” implies to create a new instance but the method returns a cached instance instead. I also changed the spec of getCallerClass per . There is not much change since webrev.01.
>>  http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-November/036589.html
> Looks good to me Mandy.
> Though I wonder whether we really need this optimization.
Thanks for the review.
Caching of StackWalker instances is not highly needed and I want to avoid the method name to preclude such possibility.
More information about the core-libs-dev