Proposed API for JEP 259: Stack-Walking API

Peter Levart peter.levart at
Wed Nov 18 09:11:05 UTC 2015

Hi Mandy,

Just one nit...

On 11/17/2015 11:59 PM, Mandy Chung wrote:
>> Apart from the orphaned paragraph fragment at the end looks good to me, but that’s just my opinion.
> I caught that that after I clicked sent :(
> This is a better version.
> /**
>   * Gets the {@code Class} object of the caller invoking the method
>   * that calls this {@code getCallerClass} method.
>   *
>   * <p> Reflection frames, {@link java.lang.invoke.MethodHandle} and
>   * hidden frames are filtered regardless of the
>   * and {@link Option#SHOW_HIDDEN_FRAMES SHOW_HIDDEN_FRAMES} options
>   * if this {@code StackWalker} has been configured.

- if this {@code StackWalker} has been configured.
+ this {@code StackWalker} has been configured with.

Otherwise I think this is fine now.

I was just thinking of getCallerClass() suitability to be an instance 
method. It requires StackWalker instance to be configured with 
SHOW_HIDDEN_FRAMES options. Do you anticipate other options in the 
future that could actually affect how getCallerClass() operates? If not, 
then perhaps it could just be a static method to simplify use. What do 
you think?

Regards, Peter

More information about the core-libs-dev mailing list