Code Review for JEP 259: Stack-Walking API

Coleen Phillimore coleen.phillimore at
Wed Nov 18 21:01:33 UTC 2015

One of the things that I'm struggling with is that StackFrameInfo 
contains both the collected information from walking the stack frames, 
method id, bci, mirror, version and cpref, and the digested information: 
interned string for class name, method name, line number and source file 

If this is to replace stack walking for exceptions, this will more than 
double the footprint of the information collected but rarely used.  I 
don't understand why the digested information isn't still StackFrameElement?

That's just a high level comment.  I haven't read the java code yet for 
the rationale why this type is used for two different things.


On 11/16/15 7:13 PM, Mandy Chung wrote:
> I’d like to get the code review done by this week.
> I renamed the static factory method from create to getInstance since “create” implies to create a new instance but the method returns a cached instance instead.  I also changed the spec of getCallerClass per [1].  There is not much change since webrev.01.
> Webrev:
> javadoc:
> Mandy
> [1]

More information about the core-libs-dev mailing list