Code Review for JEP 259: Stack-Walking API
mandy.chung at oracle.com
Fri Nov 20 02:13:37 UTC 2015
Cross-posting to core-libs-dev.
Delta webrev incorporating feedback from Coleen and Brent and also a fix that Daniel made:
This also includes a couple of new tests Hamlin has contributed.
> On Nov 19, 2015, at 1:38 PM, Coleen Phillimore <coleen.phillimore at oracle.com> wrote:
> Hi Mandy,
> Thank you for making these changes. I think it looks really good!
> On 11/19/15 4:09 PM, Mandy Chung wrote:
>> Hi Coleen,
>> Here is the revised webrev incorporating your suggestions and a couple other minor java side change:
>> I got some idea how to prepare Throwable to switch to StackWalker API to address the footprint/performance concern. I agree with you that it would have to use mid/cpref in the short term for Throwable. StackWalker::walk should use MemberName and should improve the footprint/performance issue in the long term.
>> Are you okay to follow that up with JDK-8141239 and Throwable continues to use the VM backtrace until JDK-8141239 is resolved?
> Yes, and as we discussed, I'd like to help with this.
More information about the core-libs-dev