RFR (S) 8136500: Integer/Long getChars and stringSize should be more idiomatic

Ivan Gerasimov ivan.gerasimov at oracle.com
Mon Nov 23 16:23:48 UTC 2015

Great!  Now I like it the best.

Though, it may be better to get yet another pair of eyes.

One minor nit: In the tests, in the summary, it is written, "Test 
Integer.toString method*s*", but only one of the overloads is tested.

Sincerely yours,

On 23.11.2015 18:08, Aleksey Shipilev wrote:
> On 11/23/2015 04:34 PM, Ivan Gerasimov wrote:
>> With this fixed patch:
>> http://cr.openjdk.java.net/~igerasim/8136500/8136500-addition-1.patch
>> all tests from test/lang pass.
>> Would you give it another chance?
> Okay, but this is better be the last non-cosmetic change to board this
> departing train:
>    http://cr.openjdk.java.net/~shade/8136500/webrev.05/
> This passes java/lang, java/util tests, and performance improvement is
> still very good.
> Thanks,
> -Aleksey

More information about the core-libs-dev mailing list