Code (Pre-)Review for JEP 280: Indify String Concat

Aleksey Shipilev aleksey.shipilev at
Sun Nov 29 18:23:43 UTC 2015

Hi Maurizio,

Updated webrevs:

On 11/27/2015 10:13 PM, Maurizio Cimadamore wrote:
> Looks great - the only minor quibble is that now StringConcat looks like
> a regular javac context class; it even has an instance method - it's
> therefore best to follow usual initialization pattern for javac components:

That makes sense. I had a concern that Gen and StringConcat are
circularly dependent on each other, but this seems to be handled by
exposing the underconstructed Gen early.


More information about the core-libs-dev mailing list