RFR: 8143926: ObjectStreamField constructor eagerly load ObjectStreamClass
Alan.Bateman at oracle.com
Mon Nov 30 15:37:59 UTC 2015
On 30/11/2015 11:54, Chris Hegarty wrote:
> On 30/11/15 11:31, Claes Redestad wrote:
>> On 2015-11-30 11:38, Chris Hegarty wrote:
>>>> I'm OK with moving these utility methods to a more neutral place, but
>>>> since the BytecodeDescriptor utilities are public for now, maybe this
>>>> should be a follow-up once/if
>>>> these classes become properly encapsulated?
>>> I see that BytecodeDescriptor has methods that offer similar
>>> functionality, but if the primary motivation is to reduce the
>>> number of classes loaded when ObjectStreamField is loaded, then
>>> maybe the simplest thing to do is to move getClassSignature
>>> to ObjectStreamField?
>> Yes, this would be the primary motivation, and shuffling some methods
>> from ObjectStreamClass to ObjectStreamField works for this purpose. Mind
>> if I tidy things up a bit?
> This looks ok to me Claes.
This version looks okay to me too although the /*package-private*/
comments are a bit distracting here, esp. as this area doesn't usually
More information about the core-libs-dev