RFR:8143413:add toEpochSecond methods for efficient access
scolebourne at joda.org
Mon Nov 30 18:37:38 UTC 2015
This is based on user difficulties picked up via Stack Overflow. These
methods aim to provide a simpler and faster approach, particularly for
cases converting to/from java.util.Date.
For the time cases, the convention of 1970-01-01 is natural and
commonly used in many codebases.
On 30 November 2015 at 18:15, Xueming Shen <xueming.shen at oracle.com> wrote:
> While it is kinda understandable to have LocalDate.toEpochSecond(...)
> to get the epoch seconds since 1970.1.1, with the assumption of the
> time is at the midnight of that day. It is strange to have the
> to have two public methods with the assumption of the "date" is at epoch
> year/month/day. What's the use case/scenario for these two proposed
> On 11/30/2015 06:36 AM, Stephen Colebourne wrote:
>> The method Javadoc (specs) for each of the three new methods needs to
>> be enhanced.
>> For the date ones it needs to say
>> "The resulting date will have a time component of midnight at the
>> start of the day."
>> For the time ones it needs to say
>> "The resulting time will be on 1970-01-01."
>> Some of the line wrapping in the tests looks like it is not indented
>> Otherwise looks fine,
>> On 30 November 2015 at 11:50, nadeesh tv<nadeesh.tv at oracle.com> wrote:
>>> Hi all,
>>> Please review a fix for
>>> Bug Id -https://bugs.openjdk.java.net/browse/JDK-8143413
>>> Issue - add toEpochSecond methods for efficient access
>>> webrev - http://cr.openjdk.java.net/~ntv/8143413/webrev.01/
>>> -- Thanks and Regards,
>>> Nadeesh TV
style="border-top: 1px solid #aaabb6; margin-top: 10px;">
<td style="width: 105px; padding-top: 15px;">
<td style="width: 470px; padding-top: 20px; color: #41424e;
font-size: 13px; font-family: Arial, Helvetica, sans-serif;
line-height: 18px;">This email has been sent from a virus-free
computer protected by Avast. <br /><a
target="_blank" style="color: #4453ea;">www.avast.com</a>
</table><a href="#DDB4FAA8-2DD7-40BB-A1B8-4E2AA1F9FDF2" width="1"
More information about the core-libs-dev