RFR(xxs): 8139037: [aix] Crash in ResolverConfigurationImpl.c - pointer shearing
goetz.lindenmaier at sap.com
Thu Oct 8 12:45:59 UTC 2015
the change looks good. Thanks for fixing this.
From: ppc-aix-port-dev [mailto:ppc-aix-port-dev-bounces at openjdk.java.net] On Behalf Of Thomas Stüfe
Sent: Mittwoch, 7. Oktober 2015 16:28
To: Java Core Libs; ppc-aix-port-dev at openjdk.java.net
Subject: RFR(xxs): 8139037: [aix] Crash in ResolverConfigurationImpl.c - pointer shearing
please review and sponsor this AIX fix.
in ResolverConfigurationImpl.c, we may crash because strchr() is used without prototype, which causes the C compiler to default to an int return type, which means we loose the upper 32bit of the pointer returned by strchr().
The solution is to include string.h.
Before, string.h was conditionally included for all platforms but AIX - reason is not really clear to me. But as strchr() is POSIX and always in string.h, I included string.h unconditionally for all Unices.
Kind Regards, Thomas
More information about the core-libs-dev