RFR (M) 8140802 - Clean up and refactor of class loading code for CDS
coleen.phillimore at oracle.com
Fri Oct 30 19:44:30 UTC 2015
This is a manageable code change.
You forward declare Klass* but don't use it in this header file.
Also can you add a comment to #endif to say what it's endifing. ie. //
33 TempNewSymbol class_name_symbol = SymbolTable::new_permanent_symbol(parser->current_class_name(), THREAD);
This doesn't make sense. If you want a permanent symbol, it doesn't
need to get un-reference counted with the TempNewSymbol destructor.
+ // Make sure we have an entry in the SystemDictionary on success
This assert code is a copy of some code elsewhere. Can you make it a
function that they boh can call?
Can you also comment the raw #endif's to what they're endifing?
Otherwise, this looks okay.
On 10/30/15 1:00 PM, Ioi Lam wrote:
> Please review the following fix:
> Bug: Clean up and refactor of class loading code for CDS
> Summary of fix:
> We need to clean up and refactor the class loading code in order
> to support CDS in JDK9
>  Remove code that has been made obsolete by the module changes
> (such as supporting code used for meta-index file)
>  Add new whitebox API to be used by CDS-related tests.
>  Refactor the parsing of classlist files for future enhancements.
>  Add new APIs in the class loading code to support Oracle CDS
> RBT - with same set of tests as hs-rt nightly
> - Ioi
More information about the core-libs-dev