RFR (M) 8140802 - Clean up and refactor of class loading code for CDS
jiangli.zhou at oracle.com
Fri Oct 30 20:23:53 UTC 2015
The change looks pretty clean. The new src/share/vm/classfile/systemDictionary_ext.hpp and src/share/vm/classfile/vmSymbols_ext.hpp do not have copyright header. Please add the copyright headers. Please also fix the copyright year for the modified files prior to pushing.
In src/share/vm/classfile/sharedPathsMiscInfo.hpp, is the new “#include “classify/classLoader.hpp” necessary?
I agree with the comments from Colleen and Karen regarding the usage of new_permanent_symbol() and TempNewSymbol in classLoaderExt.cpp. It doesn’t seem to be consistent.
> On Oct 30, 2015, at 10:00 AM, Ioi Lam <ioi.lam at oracle.com> wrote:
> Please review the following fix:
> Bug: Clean up and refactor of class loading code for CDS
> Summary of fix:
> We need to clean up and refactor the class loading code in order
> to support CDS in JDK9
>  Remove code that has been made obsolete by the module changes
> (such as supporting code used for meta-index file)
>  Add new whitebox API to be used by CDS-related tests.
>  Refactor the parsing of classlist files for future enhancements.
>  Add new APIs in the class loading code to support Oracle CDS enhancements.
> RBT - with same set of tests as hs-rt nightly
> - Ioi
More information about the core-libs-dev