RFR: jsr166 jdk9 integration wave 6
martinrb at google.com
Sun Apr 3 21:08:50 UTC 2016
Thanks for the review!
On Sun, Apr 3, 2016 at 12:34 PM, Remi Forax <forax at univ-mlv.fr> wrote:
> Hi Martin,
> for http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/miscellaneous/
> aka introducing a new constructor seems to be a regression to me,
> the less overloads we have the better i understand the code.
For "telescoping constructors" and a parameter that's almost always
null, I disagree.
There's also the fear that the VM won't optimize away useless volatile
write to next.
> ParkLoops test is fine too, i suppose it's related to the recent change in the code of TimeUnit to test with different units.
No, it fixes a mistake made when introducing timeout factor scaling.
The webrev has a link to the bug report
More information about the core-libs-dev