RFR: JDK-8152622: tools/pack200/Pack200Props.java timed out
Alan.Bateman at oracle.com
Wed Apr 6 08:39:22 UTC 2016
On 06/04/2016 04:47, Kumar Srinivasan wrote:
> I made some adjustments, based on private feedback.
> New Webrev:
> * Modified ModuleAttributes test to use the new utility method,
> this also requires a way to filter/select filename patterns.
> * Use preVisitDirectory to create directories once, and ignore
> /packages directories.
Creating a zip file from the classes in the jrt file system make sense,
and should be fast.
A few comments on Utils.JrtToZip:
- the URI creation in the run() method isn't reliable, could you use
URI uri = URI.create("jar:" + outFile.toURI());
- In the toZipFs method then I assume you should use
URI.create("jrt:/"), best to stay away from URL.
- Is Files.createDirectories needed? The walk is specified to be depth
first so you'll also visit parent directories first.
- I'm also curious about the REPLACE_EXISTING as I assume that isn't needed.
A minor comment is that "root" rather than "p" would be nicer for the
root directory. Personally I would avoid the really long lines as it
makes future side-by-side reviews harder. Also throws Exception seems
too broad but it's test code so not a big deal.
More information about the core-libs-dev