RFR: jsr166 jdk9 integration wave 6

Paul Sandoz paul.sandoz at oracle.com
Thu Apr 7 13:17:13 UTC 2016

> On 6 Apr 2016, at 22:17, Martin Buchholz <martinrb at google.com> wrote:
> We missed Aleksey's changes, which broke our integration.

Looks good.

Regarding CompletableFutureTest.testManyDependents i presume that kind of test was not failing before the modifications to CompletableFuture?

I am struggling to square the CF updates to the test. AFAICT the cleaning of a CF stack is now less aggressive. A dependent’s stack stack will now only be cleared if it has not completed (rather than if also the computation is nested). Thus in theory that test should run more efficiently?


> Historically, hotspot was more independent from jdk, and there were no
> "flag days" that required both to be modified together.
> In jsr166 CVS we still consistently use sun.misc.Unsafe, because it's
> ... ummm ... more portable.
> Our openjdk integration script changes that to jdk.internal.misc, but
> needs modification.
> Most of these will sadly soon change again, due to varhandlification.
> Everything regenerated, now with:
> # Replaces sun.misc.Unsafe with jdk9's preferred jdk.internal.misc
> find src/main -name '*.java' \
>  | xargs perl -pi -0777 \
>  -e 's~\bsun\.misc\.Unsafe\b~jdk.internal.misc.Unsafe~g;
>      s~\bputOrdered([A-Za-z]+)\b~put${1}Release~g'
> On Wed, Apr 6, 2016 at 5:54 AM, Paul Sandoz <paul.sandoz at oracle.com> wrote:
>> Hi Martin,
>> miscellaneous
>> You reverted Aleksey’s change s/putOrderedObject/putObjectRelease.
>> The *Ordered* methods are now removed from the “real” jdk.internal.misc.Unsafe.
>> Paul.
>>> On 3 Apr 2016, at 20:29, Martin Buchholz <martinrb at google.com> wrote:
>>> Easy changes to review, up to April Fools day, in part to make room
>>> for later unfinished more exciting changes.
>>> http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/

More information about the core-libs-dev mailing list