RFR: jsr166 jdk9 integration wave 6
paul.sandoz at oracle.com
Thu Apr 7 15:29:55 UTC 2016
> On 7 Apr 2016, at 16:55, Martin Buchholz <martinrb at google.com> wrote:
> On Thu, Apr 7, 2016 at 6:17 AM, Paul Sandoz <paul.sandoz at oracle.com> wrote:
>>> On 6 Apr 2016, at 22:17, Martin Buchholz <martinrb at google.com> wrote:
>> Looks good.
>> Regarding CompletableFutureTest.testManyDependents i presume that kind of test was not failing before the modifications to CompletableFuture?
> Right - technically it was not failing before, but the O(N^2)
> performance in case of regression would be noticed quickly. And it
> seems like a generally useful test.
Yes, no disagreement.
>> I am struggling to square the CF updates to the test. AFAICT the cleaning of a CF stack is now less aggressive. A dependent’s stack stack will now only be cleared if it has not completed (rather than if also the computation is nested). Thus in theory that test should run more efficiently?
> It's not useful to clean the stack of a future that has completed
> because all of its dependents will be triggered anyways, so there's no
> risk of garbage accumulation. But jsr166 CVS already has followon
> changes in this area that are not part of this integration.
I was looking at those trying to understand where things are going.
Current webrev is fine.
More information about the core-libs-dev