RFR [9] 8137058: Clear out all non-Critical APIs from sun.reflect and move to jdk.unsupported

Alan Bateman Alan.Bateman at oracle.com
Wed Apr 13 15:59:20 UTC 2016

On 13/04/2016 16:43, Chris Hegarty wrote:
> This review is for the second significant part of the changes for JEP
> 260 [1]. When created, the jdk.unsupported module [2] initially
> contained the sun.misc package. This issue is will move all the
> non-Critical APIs out of sun.reflect, leaving only the critical ones, at
> which point sun.reflect can be moved to the jdk.unsupported module.
> http://cr.openjdk.java.net/~chegar/8137058/
> https://bugs.openjdk.java.net/browse/JDK-8137058
This looks good. A few comments:

I assume the new sun.reflect.Reflection should have a private 
constructor to prevent it being instantiated. You've probably thought 
about this already but I assume the @Deprecated in 
Reflection.getCallerClass should reference the supported API.

The changes to InetAddress don't seem unrelated but good.


More information about the core-libs-dev mailing list