RFR: JDK-8147460: Clean-up jrtfs implementation
xueming.shen at oracle.com
Thu Apr 14 19:07:08 UTC 2016
On 04/14/2016 11:57 AM, Alan Bateman wrote:
> On 13/04/2016 19:55, Xueming Shen wrote:
>> Please hep review the cleanup changes for jrtfs implementation.
> I'm skimmed through the changes and it looks very good.
> My only concern is that we might have not enough tests for jrtfs to exercise it completely. I just checked the coverage it is indeed quite low. I'll create a bug for this.
> In passing, in JrtDirectoryStream then the spec allows for read ahead and so the original implementation was okay to return this when closed. What you have is fine, just pointing out that both behaviors are allowed.
There is a test that passing a null filter into Files.newDirectoryStream(path, filter)
and then FileSystemProvider.newDirectoryStream(...), to mean "no filter". My reading
of the spec suggests it should get a NPE. (to use the nweDirectoryStream(dir) for
accept all). Can you confirm?
More information about the core-libs-dev