RFR 8154733, Fix module dependencies missed in java.rmi tests
amy.lu at oracle.com
Tue Apr 26 13:38:14 UTC 2016
On 4/26/16 8:50 PM, Felix Yang wrote:
> Hi Amy,
> thanks for pointing this out. Updated webrev:
Thank you Felix for the updated webrev. This looks clear and good :-)
Just one question, does this fix for all tests for jdk_rmi test group?
does not declare java.logging dependency.
Seems same to jdk/test/sun/rmi/runtime/Log/checkLogging/CheckLogging.java
I did not do full check though. (It's fine if other tests are tracked by
As I'm not reviewer, please wait for reviewer's feedback.
> On 2016/4/26 17:21, Amy Lu wrote:
>> Hi, Felix
>> With modules declares in TEST.propertiesshould avoid have to modify
>> test file one by one... Maybe I missed things please correct me.
>> $ cat jdk/test/java/rmi/TEST.properties
>> modules = java.rmi
>> On 4/26/16 4:53 PM, Felix Yang wrote:
>>> Hi all,
>>> please review the fix to explicitly declare module dependencies
>>> for rmi tests.
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8154733
>>> Webrev: http://cr.openjdk.java.net/~xiaofeya/8154733/webrev.00/
More information about the core-libs-dev