RFR(s): 8170664: SystemLoggerInPlatformLoader.java failing in case of module limitation

Daniel Fuchs daniel.fuchs at oracle.com
Tue Dec 6 10:04:15 UTC 2016

On 06/12/16 09:36, Sergei Kovalev wrote:
> Hi Daniel,
> Please take a look at
> http://cr.openjdk.java.net/~skovalev/8170664/webrev.01/

Hi Sergey,

This looks good.

Please add a comment to explain why we're doing this here:

111         if (simleConsoleOnly) {
                 // happens if the test is called with
                 // --limit-modules java.base

> This simplify logic a bit. What if JDK uses some custom logging library
> instead of java.logging? Looks like in this case the test will expect
> SimpleConsoleLogger but it could be not a case. Isn't it? Does it matter
> for testing?

The test runs in a controlled environment. The JDK has no
'custom library'. An application might, but there are other
tests for that.
So in the case we're testing here it's either java.logging present
or java.logging absent - and no other alternative.

best regards,

-- daniel


More information about the core-libs-dev mailing list