RFR 9: JDK 8170831: ZipFile implementation no longer caches the last accessed entry/pos

Xueming Shen xueming.shen at oracle.com
Wed Dec 7 00:14:15 UTC 2016


Please help review.commit the proposed change for JDK8170831

issue: https://bugs.openjdk.java.net/browse/JDK-8170831
webrev: http://cr.openjdk.java.net/~sherman/8170831/

(1) As explained in the issue description, the new implementation now 
does not have the cache
mechanism as the old C implementation does (the C implementation still 
is still in repo, take a
look at  
the corresponding cache is stored in zip->cache, "zip_util.h#trypedef 
struct jzfile/cache".

(2) instead of having this cache in class ZipFile.Source, the cached 
pair is now at ZipFile
level for simplicity.

(3) I now simply compare the identity of the entry "name", to avoid the 
unnecessary string
comparing operation, with the assumption that it's rare that someone 
will replace the entry
name filed of the returned ZipEntry with a new String object with the 
same value and come
back for the InputStream.

(4) given currently there is no easy way to generate a zip/jar file with 
same entry name
in test case (out ZipInputStream does not such use scenario, with an 
exception), I'm not adding
new test case as the regression test, but I do have verified the change 
with the jar files that have
entries with same name but different bytes.



More information about the core-libs-dev mailing list