RFR: 8054214: JapaneseEra.getDisplayName doesn't return names if it's an additional era
jbluettduncan at gmail.com
Thu Dec 8 11:52:47 UTC 2016
I'm not a reviewer, but there's something in JapaneseEra.java.cdiff.html
isn't terribly clear to me, so I wonder if you could clarify it for me.
In the method `getDisplayName(TextStyle style, Locale locale)`, it's not
clear to me why the call to `Objects.requireNonNull(locale, "locale");` is
within the if-statement rather than on the first line. Is this because
`Era.super::getDisplayName` already has a null check of its own?
On 8 December 2016 at 08:55, Masayoshi Okutsu <masayoshi.okutsu at oracle.com>
> Please review the fix for JDK-8054214. It was necessary to override
> Era::getDisplayName to get era names from the specified property. This one
> fixes getAbbreviation() as well.
More information about the core-libs-dev