<i18n dev> RFR: 8054214: JapaneseEra.getDisplayName doesn't return names if it's an additional era
scolebourne at joda.org
Tue Dec 13 13:24:35 UTC 2016
The overridden method includes full Javadoc and an @since 9 tag. I
believe that this Javadoc should not be present and the @since tag is
On 11 December 2016 at 02:26, Masayoshi Okutsu
<masayoshi.okutsu at oracle.com> wrote:
> Thank you for the review comments. I realized that only TextStyle.NARROW and
> NARROW_STANDALONE should return the abbreviation to be consistent with
> locale data. I've changed the implementation, which should have "fixed" the
> NPE issue, and added more test cases.
> Revised webrev:
> While I was testing more, I realized the default implementation of
> Era.getDisplayName doesn't work with non-IsoChronology. I filed new bug
> report JDK-8171049.
> On 12/8/2016 5:55 PM, Masayoshi Okutsu wrote:
>> Please review the fix for JDK-8054214. It was necessary to override
>> Era::getDisplayName to get era names from the specified property. This one
>> fixes getAbbreviation() as well.
More information about the core-libs-dev