(urgent) RFR: JDK-8171245: Solaris builds fails after JDK-8170663

David Holmes david.holmes at oracle.com
Wed Dec 14 21:09:22 UTC 2016

Thanks Erik.

On 15/12/2016 4:23 AM, Erik Joelsson wrote:
> Hello,
> Please review this small fix for a warning in java_md_solinux.c which
> was introduced with JDK-8170663. The error message is:
> "/opt/jprt/jprtadm/erik/jdk9-dev/jdk/src/java.base/unix/native/libjli/java_md_solinux.c",
> line 519: error: declaration can not follow a statement

Very surprised the Solaris compiler does not handle declarations at any 
point. I thought only the Visual Studio compiler still had such archaic 

That aside the change should have been tested before being pushed - 
preferably through JPRT - but was not.


> My attempted fix just adds a new scope around the new variable
> declaration and it's use. That pattern seems to be used several times
> already in the file.
> This bug is currently preventing all Solaris builds at Oracle.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8171245
> Webrev: http://cr.openjdk.java.net/~erikj/8171245/webrev.01/
> /Erik

More information about the core-libs-dev mailing list