RFR:JDK-8145633-Adjacent value parsing not supported for Localized Patterns

Roger Riggs Roger.Riggs at Oracle.com
Tue Dec 20 15:18:41 UTC 2016

Hi Nadeesh,

A nice bit of work.

   4774:  A note about the design to delay the choice of TemporalField and
              creating PrinterParser until the locale is known would be 
   4789:  Please add the @param descriptions so the purpose of the new 
arguments is clear
   4795:  Documenting the 5 arg constructor may be useful too
   4871:  wrap this long line


  85-87:  Single character field names are too cryptic;  and could be 
final and static?

Thanks, Roger

On 12/20/2016 4:55 AM, nadeesh tv wrote:
> Hi all,
> BugId: https://bugs.openjdk.java.net/browse/JDK-8145633
> Issue:  Support adjacent value parsing for  Localized Patterns
> Webrev:  http://cr.openjdk.java.net/~ntv/8145633/webrev.10/
> Pattern 'c' and 'W'  were previously allowed to have 'zero padding' 
> which was not explicitly mentioned in CLDR 
> (http://unicode.org/reports/tr35/tr35-dates.html).
> To allow 'c' and 'W' to take part in adjacent value  parsing ( at the 
> same time, 2 digits are  not required for these patterns), restricted 
> the max width of these patterns to 1.
> Special thanks to Stephen for the help.

More information about the core-libs-dev mailing list