RFR(s): 8171958: Several tests from java/time/test/java/time/format requiring jdk.localedata for execution

Sergei Kovalev sergei.kovalev at oracle.com
Mon Dec 26 14:57:54 UTC 2016

Hello Team,

Please review below fix for tests.

Bug ID: https://bugs.openjdk.java.net/browse/JDK-8171958
Web review: http://cr.openjdk.java.net/~skovalev/8171958/webrev.00/

Issue: some tests fails in case of module limitation by '--limit-module 
java.base' command line option.
Root cause: The tests uses locale data that stored in separate resource 
file "jdk.localedata".
Solution: Add declaration of required module. In same cases a test file 
contains many test items, part of which could be executed with java.base 
module only. In this cases we can separate the items and extract that 
items which depend on locale data and run them individually. Therefore 
this proposal contains additional test files where added "WithLocale" 
suffix which demonstrate dependency on resources. Alternative solution 
could be add a required module declaration "jdk.localedata" to all 
files. However this will lead to unnecessary test coverage reduction.

With best regards,

More information about the core-libs-dev mailing list