RFR(s): 8171958: Several tests from java/time/test/java/time/format requiring jdk.localedata for execution

nadeesh tv nadeesh.tv at oracle.com
Tue Dec 27 06:04:11 UTC 2016

Hi Sergei,

I could see you modified tests only in 
/test/java/time/*test*/java/time/format/ directory.

Won't the tests from test/java/time/*tck*/java/time/format/ directory  
fail with same issue?

Thanks and Regards,

On 12/26/2016 8:27 PM, Sergei Kovalev wrote:
> Hello Team,
> Please review below fix for tests.
> Bug ID: https://bugs.openjdk.java.net/browse/JDK-8171958
> Web review: http://cr.openjdk.java.net/~skovalev/8171958/webrev.00/
> Issue: some tests fails in case of module limitation by 
> '--limit-module java.base' command line option.
> Root cause: The tests uses locale data that stored in separate 
> resource file "jdk.localedata".
> Solution: Add declaration of required module. In same cases a test 
> file contains many test items, part of which could be executed with 
> java.base module only. In this cases we can separate the items and 
> extract that items which depend on locale data and run them 
> individually. Therefore this proposal contains additional test files 
> where added "WithLocale" suffix which demonstrate dependency on 
> resources. Alternative solution could be add a required module 
> declaration "jdk.localedata" to all files. However this will lead to 
> unnecessary test coverage reduction.

Thanks and Regards,
Nadeesh TV

More information about the core-libs-dev mailing list