RFR(s): 8171958: Several tests from java/time/test/java/time/format requiring jdk.localedata for execution

Rachna Goel rachna.goel at oracle.com
Tue Dec 27 10:55:36 UTC 2016

Hi Sergei,

Though I am not a reviewer, But I have one comment on this fix.

test/java/time/TEST.properties declares "modules = jdk.localedata" , so 
that all tests for java.time can have access to "jdk.localedata" module.

If we are restricting usage of jdk.localedata module for different 
tests, then TEST.properties need to be updated as well.


On 26/12/16 8:27 PM, Sergei Kovalev wrote:
> Hello Team,
> Please review below fix for tests.
> Bug ID: https://bugs.openjdk.java.net/browse/JDK-8171958
> Web review: http://cr.openjdk.java.net/~skovalev/8171958/webrev.00/
> Issue: some tests fails in case of module limitation by 
> '--limit-module java.base' command line option.
> Root cause: The tests uses locale data that stored in separate 
> resource file "jdk.localedata".
> Solution: Add declaration of required module. In same cases a test 
> file contains many test items, part of which could be executed with 
> java.base module only. In this cases we can separate the items and 
> extract that items which depend on locale data and run them 
> individually. Therefore this proposal contains additional test files 
> where added "WithLocale" suffix which demonstrate dependency on 
> resources. Alternative solution could be add a required module 
> declaration "jdk.localedata" to all files. However this will lead to 
> unnecessary test coverage reduction.

More information about the core-libs-dev mailing list