RFR 9: 8150346 : java/lang/ProcessHandle/Infotest.java failed: startTime after process spawn completed

Martin Buchholz martinrb at google.com
Mon Feb 29 22:09:48 UTC 2016

Just nitpicks - your change is approved!

                     while ((s = lines.readLine()) != null) {

I think it's better style to localize

                    for  (String s; (s = lines.readLine()) != null; ) {

 121                 String s = lines.readLine();

I think it's better style to write to a local that's never used.
In my old test TimedAcquireLeak I synchronize with child by
reading/writing just one byte.

        public static void main(String[] args) throws Throwable {
            // Synchronize with parent process, so that jps can find us

On Tue, Feb 23, 2016 at 2:30 PM, Roger Riggs <Roger.Riggs at oracle.com> wrote:
> Please review a test fix to resolve a timing race with the start time of a
> spawned process.
> Webrev:
>   http://cr.openjdk.java.net/~rriggs/webrev-start-8150346/
> Jira:
>    https://bugs.openjdk.java.net/browse/JDK-8150346
> Thanks, Roger

More information about the core-libs-dev mailing list