RFR: JDK-8144144 - ORB destroy() leaks filedescriptors after unsuccessful connection
sean.coffey at oracle.com
Wed Jan 20 18:17:24 UTC 2016
line 125, could you use a 2 arg method call to dprint. It'll print the
stacktrace instead :
dprint(".close: selector.close: " + t); --> dprint(".close:
The "while (!isClosed()) " change introduces a new hot lock on closed
variable. Hopefully, it won't impact performance too much.
Looks good to me otherwise.
On 20/01/16 16:16, Mark Sheppard wrote:
> an update has been made to the webrev
> an anomaly was found in the select loop of the SelectorImpl.run() method
> some defensive programming, for selector null references, have been
> added, also.
> On 08/01/2016 17:49, Mark Sheppard wrote:
>> please oblige and review the following changes
>> which addresses the issue
>> the changes ensure that an Acceptor and its associated
>> are closed.
More information about the core-libs-dev