RFR: 8147607: Remove test library dependency on sun.security.tools.jarsigner.Main
sean.mullan at oracle.com
Thu Jan 28 17:25:00 UTC 2016
On 01/28/2016 10:17 AM, Chris Hegarty wrote:
> On 28 Jan 2016, at 15:16, Wang Weijun <weijun.wang at oracle.com> wrote:
>> Shouldn't you also include the FileOuputStream in try-with-resources?
> It is. Do you need to refresh your browers?
If you read the code quickly, I missed it too, maybe it would be better
to put the opening brace on a separate line, i.e.:
try (ZipFile in = new ZipFile("multi-release.jar");
FileOutputStream os = new
... no strong opinion on that though.
>>> On Jan 28, 2016, at 5:32 PM, Chris Hegarty <chris.hegarty at oracle.com> wrote:
>>> On 28 Jan 2016, at 00:35, Steve Drach <steve.drach at oracle.com> wrote:
>>>> Please review a small change to the zipfs test library.
>>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8147607
>>>> Webrev: http://cr.openjdk.java.net/~sdrach/8147607/webrev
>>>> This change uses the public jdk.security.jarsigner.JarSigner API rather than the API exposed by sun.security.tools.jarsigner.
>>> Thanks for doing this Steve. Your changes look fine.
More information about the core-libs-dev