RFR JDK-8155616: java/util/zip/TestLocalTime.java fails intermittently with storing mtime failed
xueming.shen at oracle.com
Tue Jul 19 15:24:52 UTC 2016
webrev has been updated accordingly for the copyright header.
On 7/19/16 12:24 AM, Amy Lu wrote:
> Thanks for the fix, really a corner case.
> I think this looks reasonable.
> Just one minor thing, please update copyright header on the year when
> BTW. I'm not official reviewer.
> On 7/19/16 2:23 PM, Xueming Shen wrote:
>> Hi Amy,
>> I finally got to the bottom of this failure. It appears the
>> timestamps that
>> trigger the failure are those that (1) < 1980 and (2) within the
>> daylight saving
>> time gap, which means the local date-time is actually not valid, for
>> 1968-04-28/2:51:25, this ldt should be adjusted to 3:51:25 when switched
>> to summer time. This is really a corner case that should not have any
>> impact to real world use scenario. The implementation itself is
>> correct. Just the
>> test case need adjusted. Please help review.
>> issue: https://bugs.openjdk.java.net/browse/JDK-8155616
>> webrev: http://cr.openjdk.java.net/~sherman/8155616/webrev
More information about the core-libs-dev