RFR: 8073872: Schemagen fails with StackOverflowError if element references containing class
lance.andersen at oracle.com
Fri Mar 25 19:47:42 UTC 2016
Yes I looked at everything
On Mar 25, 2016, at 3:45 PM, Aleksej Efimov <aleksej.efimov at oracle.com> wrote:
> Thank you for review Lance!
> Small question for clarification: Can I count your review for JDK8 changes too?
> Best Regards,
> On 03/25/2016 08:46 PM, Lance Andersen wrote:
>> Looks OK Alejsej
>> On Mar 24, 2016, at 7:38 PM, Aleksej Efimov <aleksej.efimov at oracle.com> wrote:
>>> Please, help to review the fix for JDK-8073872 . In JDK9 this bug was fixed as part of sync with upstream JAXWS project . The changes that fixed stack overflow issue are located in XmlSchemaGenerator class .
>>> JDK9 change that needs review is the addition of regression test for this issue:
>>> I will be requesting JDK8 approval for partially backporting the fix for this bug to 8u-dev. Can I also ask to review the JDK8 changes:
>>> Both JDK8/9 changes were tested with JCK/JTREG tests and no failures were observed. New test passes with the fix and successfully reproduces reported stack overflow on JDKs without the fix.
>>> Best Regards,
>>>  https://bugs.openjdk.java.net/browse/JDK-8073872
>>>  https://bugs.openjdk.java.net/browse/JDK-8150174
>>>  http://hg.openjdk.java.net/jdk9/jdk9/jaxws/rev/ebff1bd3627a#l3.2
>> <Mail Attachment.gif>
>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering
>> 1 Network Drive
>> Burlington, MA 01803
>> Lance.Andersen at oracle.com
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com
More information about the core-libs-dev