Review request JDK-8153944: wsimport and wsgen usage messages not printed
lance.andersen at oracle.com
Wed May 25 19:49:09 UTC 2016
I looked at this also and do not see anything glaring.
> On May 25, 2016, at 3:45 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> On 25/05/2016 20:29, Mandy Chung wrote:
>> wsgen and wsimport tools use the utility classes in java.xml.bind module to localize messages. Resource bundles are encapsulated in named modules and hence utility like com.sun.istack.internal.localization.LocalizableMessageFactory.
>> The owner of the resource bundle should be the one loading ResourceBundle. The solution to this type of issue is to update the utility classes to accept a function to return ResourceBundle rather than by base name. Another alternative could do the localization locally within the module and this may not be applicable to JAX-WS since jdk.xml.ws is tightly coupled with java.xml.ws.
>> Webrev at:
>> This patch touches quites a few files, one per supporting class to get messages from one resource bundle. The change is straight-forward and same pattern applies to each message file.
> I don't know area but I looked at the changes and I get the gist of this. It would be good if Aleksej could review as he's the current connection to the upstream project that owns this code.
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
More information about the core-libs-dev