RFR: 8165492: Reduce number of lambda forms generated by MethodHandleInlineCopyStrategy

Aleksey Shipilev shade at redhat.com
Thu Sep 8 18:56:26 UTC 2016


On 09/08/2016 08:03 PM, Claes Redestad wrote:
> Webrev: http://cr.openjdk.java.net/~redestad/8165492/webrev.01/

It is a bit sad that we have to bust the doors with internal APIs, and
not use the public API, thus robbing ourselves of the opportunity to
optimize the public API for a wide range of use cases.

Barring that, the patch looks good.

> On 09/08/2016 09:21 PM, Paul Sandoz wrote: 
> Did you consider replacing the if block with an assert? presumably if
> it is non-zero it is an internal error?

The original check was to guard against Unsafe.allocateUnitializedArray
usage, and so I would like to keep the code that checks the index
unconditionally. asserts can be disabled.


More information about the core-libs-dev mailing list