RFR (JAXP) JDK-8087303 LSSerializer pretty print does not work anymore
shade at redhat.com
Mon Sep 12 10:45:28 UTC 2016
On 09/12/2016 12:54 PM, Frank Yuan wrote:
> Would you like to review http://cr.openjdk.java.net/~fyuan/8087303/webrev.01/?
Not an expert in the XML parsing area, so only a cursory code review:
*) Bad camel casing:
113 protected boolean m_ispreserveSpace = false;
*) shouldHandleText(chars, start, length) predicates within a method
can be computed once at the beginning?
*) I wonder if you want to check "length() > 0" before doing delete in
clearPendingWhiteSpaceText() which is frequently called
*) "this." inconsistency here:
3241 m_ispreserveSpace = false;
More information about the core-libs-dev