RFR: 8165723: JarFile::isMultiRelease() method returns false when it should return true

Alan Bateman Alan.Bateman at oracle.com
Mon Sep 12 14:24:27 UTC 2016

On 10/09/2016 01:58, Claes Redestad wrote:

> Hi,
> JDK-8152733 introduced a corner-case where isMultiRelease returns
> false when it should return true due to an erroneously hand-crafted
> Boyer-Moore search.
> Webrev: http://cr.openjdk.java.net/~redestad/8165723/webrev.01/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8165723
> Testing: created a test reproducer using randomly constructed
> manifests and verified the supplied jar is properly detected as being
> multi-release.
This looks okay. For the MultiReleaseJarAPI test then you probably 
should use jdk.testlibrary.RandomFactory so that the seed is recorded in 
the output for when the test fails. Also in CreateMultiReleaseTestJars 
then it might be cleaner to have a separate method to add extra stuff to 
the JAR file - I think that would make the usages a bit easier to read.


More information about the core-libs-dev mailing list