RFR: 8163798: Create a JarFile versionedStream method

Paul Sandoz paul.sandoz at oracle.com
Mon Sep 12 18:37:04 UTC 2016

> On 11 Sep 2016, at 13:12, Steve Drach <steve.drach at oracle.com> wrote:
> I made a simple change, the new webrev is http://cr.openjdk.java.net/~sdrach/8163798/webrev.02/ <http://cr.openjdk.java.net/~sdrach/8163798/webrev.02/>

I don’t like the state interplay between allowedVersions and getBaseSuffix, and the filtering for null. Consider merging filter.map.filter into a single flatMap.

Also can getJarEntry ever return null?

Claes makes a good point regarding performance. I would suggest getting this functional and tested then tweaking for performance.


>> On Sep 9, 2016, at 4:02 PM, Steve Drach <steve.drach at oracle.com> wrote:
>> Hi,
>> Please review this changeset that adds a VersionedStream class to the jdk.internal.util.jar package.  Some may recall that I submitted a similar RFR a few weeks ago; this is a redesign from that one.  We decided not to make a public JarFile::versionedStream method at this time.  Once we get sufficient experience with this and find a few more use cases, we will revisit the idea of making this a public method in JarFile.
>> issue: https://bugs.openjdk.java.net/browse/JDK-8163798 <https://bugs.openjdk.java.net/browse/JDK-8163798>
>> webrev: http://cr.openjdk.java.net/~sdrach/8163798/webrev.01/index.html <http://cr.openjdk.java.net/~sdrach/8163798/webrev.01/index.html>
>> Thanks,
>> Steve

More information about the core-libs-dev mailing list