RFR (JAXP) JDK-8087303 LSSerializer pretty print does not work anymore
frank.yuan at oracle.com
Tue Sep 13 02:54:12 UTC 2016
Thank you very much for your review an comments!
> -----Original Message-----
> From: Aleksey Shipilev [mailto:shade at redhat.com]
> Sent: Monday, September 12, 2016 6:45 PM
> To: Frank Yuan; 'core-libs-dev'
> Subject: Re: RFR (JAXP) JDK-8087303 LSSerializer pretty print does not work anymore
> On 09/12/2016 12:54 PM, Frank Yuan wrote:
> > Would you like to review http://cr.openjdk.java.net/~fyuan/8087303/webrev.01/?
> Not an expert in the XML parsing area, so only a cursory code review:
> *) Bad camel casing:
> 113 protected boolean m_ispreserveSpace = false;
It's to keep consistent with other members, you know, our jaxp library comes from Apache project.
> *) shouldHandleText(chars, start, length) predicates within a method
> can be computed once at the beginning?
> *) I wonder if you want to check "length() > 0" before doing delete in
> clearPendingWhiteSpaceText() which is frequently called
Yes, good suggestion, it has better performance!
> *) "this." inconsistency here:
> 3240 this.m_preserves.clear();
> 3241 m_ispreserveSpace = false;
> 3242 m_preserveSpaces.clear();
Will change to be consistent, thanks.
Anyway, because Joe suggest to make further enhancement, I will get back after making more changes.
More information about the core-libs-dev