RFR(s): 8166624: java/util/jar/JarFile/mrjar regression tests has undeclared dependencies

Sergei Kovalev sergei.kovalev at oracle.com
Sun Sep 25 12:53:38 UTC 2016

Hi Alan,

The modules list in mrar/TEST.properties guarantee that jtreg add 
"--add-module @modules" command line option during test execution. If 
you create custom JRE that does not contains the modules, the tests 
fails. The proposed fix guarantee that jtreg skips the tests if no 
listed modules found.

24.09.16 13:02, Alan Bateman wrote:
> On 23/09/2016 14:54, Sergei Kovalev wrote:
>> Hello team,
>> Could you please review a very small fix that relates to tests only.
>> BugID: https://bugs.openjdk.java.net/browse/JDK-8166624
>> Webrev: http://cr.openjdk.java.net/~skovalev/8166624/webrev.00/
> "@modules java.compiler/javax.tools" looks odd, should this be simply 
> "@modules java.compiler"?
> In any case, I would have thought that the modules list in 
> mrjar/TEST.properties was enough to ensure these tests don't run when 
> the runtime under test doesn't have jdk.jartool or jdk.compiler. But 
> perhaps the motivation of the change is to make it more fine grained?
> -Alan

With best regards,

More information about the core-libs-dev mailing list