[9] RFR of JDK-8085192: java/rmi/activation/Activatable tests fail intermittently due to "Port already in use"

Roger Riggs Roger.Riggs at Oracle.com
Tue Sep 27 15:14:37 UTC 2016

Hi Hamlin,

Marking each test that uses RMID.launch with the bugid does not seem to 
be meaningful
since the bug is in the support infrastructure of the test and not 
specific to the test itself.
It would be overkill to try to confirm the bug was fixed by running all 
those tests.
Putting the bugid on 1 of the tests would be sufficient.


  - 134-138:  Why define these private methods if they are not going to 
be used in outputContains?

- 185:  Its inefficient to convert the byte array to a string for when 
looking for each string.
     It would be cleaner for JavaVM to have public outputString and 
errorString methods
     and check them separately in RMID.
    (remove the JavaVM.outputContains method which hides which stream 
the string appeared in).

(It would be a bigger change to change this to use the test library 
ProcessTools and OutputAnalyzer).


On 9/27/2016 5:22 AM, Hamlin Li wrote:
> Please review the fix for JDK-8085192. The fix checks whether it fails 
> to launch rmid due to "Port already in use" error, it will launch rmid 
> again and again(20 times at most) until no such issue.
> bug:
>     https://bugs.openjdk.java.net/browse/JDK-8085192
> webrev:
>     http://cr.openjdk.java.net/~mli/8085192/webrev.00/
> Thank you
> -Hamlin

More information about the core-libs-dev mailing list