RFR: JDK-8186156: Fix a11y and HTML issues in java.net and javax.net packages
mandy.chung at oracle.com
Fri Aug 11 23:40:03 UTC 2017
On 8/11/17 3:52 PM, Jonathan Gibbons wrote:
> Please review the following fix for accessibility and HTML issues in
> the java.net and javax.net packages.
> The only edit of note is that a table was simply removed from the top
> of URLConnection. The table was an "HTML art" depiction of actions on
> a timeline, complete with an ASCII-art time arrow. My initial reaction
> was to replace it with an ordered list ... but then I noticed the
> table was already immediately followed by the explanatory list I would
> have written. So the table was effectively redundant, and it seemd
> best to remove it.
> JBS: https://bugs.openjdk.java.net/browse/JDK-8186156
> Webrev: http://cr.openjdk.java.net/~jjg/8186156/webrev.00
> API: http://cr.openjdk.java.net/~jjg/8186156/api.00
The table in URLConnection does look redundant. I think it's okay to
+ * <ul>
+ * <li>"POST,GET,DELETE"
+ * <li>"GET:X-Foo-Request,X-Bar-Request"
+ * <li>"POST,GET:Header1,Header2"
+ * </ul>
It may be good to add <p> in the next sentence "The first example..."
Otherwise looks fine.
More information about the core-libs-dev